Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Semantic Role Labeling task #301

Draft
wants to merge 50 commits into
base: main
Choose a base branch
from
Draft

Add Semantic Role Labeling task #301

wants to merge 50 commits into from

Conversation

rmitsch
Copy link
Collaborator

@rmitsch rmitsch commented Sep 21, 2023 •
edited
Loading

Description

This PR is for the addition of a fully working spacy pipeline for zero-shot span-based SRL using OpenAI. It includes the task, template, usage example, tests (pytest), and documentation.

Corresponding documentation PR

todo

Types of change

new feature

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran all tests in tests and usage_examples/tests, and all new and existing tests passed. This includes
    • all external tests (i. e. pytest ran with --external)
    • all tests requiring a GPU (i. e. pytest ran with --gpu)
  • My changes require a change to the documentation, and I've added all the required information.

ahmeshaf and others added 30 commits July 20, 2023 22:38
@ahmeshaf
Adding span_srl task with tests, usage and documentation
07a4f2b
@ahmeshaf
Fixing minor issues
22cba55
@ahmeshaf
adding example usage of SRL
917868b
@ahmeshaf
Merging main
0ff46ad
@ahmeshaf
Fixing format warnings
b6f4f52
@ahmeshaf
Fixing format warnings
d803b23
@ahmeshaf
Fixing format warnings
53a494c
@ahmeshaf
Fixing format warnings
dd7d9fb
@ahmeshaf
Fix Literal ImportError
0ad6063
@ahmeshaf
Fix Label assignment
15412b5
@ahmeshaf
Fix the template's preamble
fd19441
@ahmeshaf
Black formatting
b56c1d0
@ahmeshaf
imports in alphabetical order
d6564f7
@ahmeshaf
alignment_mode should be a Literal.
de68696
@ahmeshaf @rmitsch
Update spacy_llm/tasks/srl_task.py
ed07c83 
Co-authored-by: Raphael Mitsch <r.mitsch@outlook.com>
@ahmeshaf @rmitsch
Update spacy_llm/tasks/templates/span-srl.v1.jinja
472d5c7 
Co-authored-by: Raphael Mitsch <r.mitsch@outlook.com>
@ahmeshaf @rmitsch
Update spacy_llm/tests/tasks/test_span_srl.py
55a8018 
Co-authored-by: Raphael Mitsch <r.mitsch@outlook.com>
@ahmeshaf
reformatting
355241a
@ahmeshaf
Merge branch 'main' of github.com:ahmeshaf/spacy-llm
a63d610
@ahmeshaf
reformatting
84d17df
@ahmeshaf
adding test on srl roles
666c3ee
@ahmeshaf
SRLTask inherits SpanTask
cb81bdf
@ahmeshaf
Merge branch 'explosion:main' into main
c6d0dfd
@ahmeshaf
Added label definitions rendering in prompt
6ab4723
@ahmeshaf
Reformatting
037f36f
@ahmeshaf
Restructuring SRLExample and ARGRelItem
d6faecd
@ahmeshaf
added expected response
2a4e862
@ahmeshaf
Removing print statement
b380478
@ahmeshaf
Added few-shot span-srl
8fc6b8d
@ahmeshaf
Add examples path in srl docs
73bf0f6
@rmitsch rmitsch added feat/new New feature feat/task Feature: tasks labels Sep 21, 2023
@rmitsch rmitsch self-assigned this Sep 21, 2023
@rmitsch rmitsch mentioned this pull request Sep 21, 2023
Closed
3 tasks
@rmitsch rmitsch changed the title Feat/srl Adding span_srl task with tests, usage and documentation Sep 21, 2023
@rmitsch rmitsch changed the title Adding span_srl task with tests, usage and documentation Adding Semantic Role Labeling task Sep 22, 2023
@rmitsch rmitsch changed the title Adding Semantic Role Labeling task Add Semantic Role Labeling task Sep 22, 2023
@rmitsch rmitsch added the Test external Run external tests label Sep 22, 2023
rmitsch
rmitsch commented Sep 22, 2023
View reviewed changes
Copy link
Collaborator Author

@rmitsch rmitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmeshaf I refactored the task and left some comments. Also, the prediction tests fail locally. Can you look into that? Thanks! 🙏

spacy_llm/tasks/srl/parser.py Outdated Show resolved Hide resolved
spacy_llm/tests/tasks/test_srl.py Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More tests would be good - have a look at e. g. the SpanCat/NER tests for inspiration? E. g. the prompt identity tests.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working on this today

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just ping me when you're done.

@rmitsch rmitsch removed the Test external Run external tests label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmeshaf ahmeshaf ahmeshaf left review comments

Assignees

@rmitsch rmitsch

Labels
feat/new New feature feat/task Feature: tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmitsch @ahmeshaf