Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing jsonl import #85

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Missing jsonl import #85

merged 3 commits into from
Feb 28, 2023

Conversation

koaning
Copy link
Contributor

@koaning koaning commented Feb 26, 2023

I noticed the docs mentioned write_gzip_jsonl but I wasn't able to import it.

Then I noticed that it was implemented but missing from __init__.py. Hence a PR.

@adrianeboyd
Copy link
Contributor

Ah, good catch! Can you also add the parallel read method import?

@koaning
Copy link
Contributor Author

koaning commented Feb 27, 2023

I just ran black against it, but couldn't find a parallel read method. Also tried CMD + SHIFT + F against the entire project and could only find "parallel" being used in the azure pipelines file.

adrianeboyd
adrianeboyd reviewed Feb 27, 2023
View reviewed changes
srsly/__init__.py Outdated Show resolved Hide resolved
@koaning @adrianeboyd
Update srsly/__init__.py
e78afd1 
Co-authored-by: Adriane Boyd <adrianeboyd@gmail.com>
@adrianeboyd
Copy link
Contributor

Thanks!

@adrianeboyd adrianeboyd merged commit c168990 into explosion:master Feb 28, 2023
@koaning koaning deleted the patch-1 branch February 28, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianeboyd adrianeboyd adrianeboyd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koaning @adrianeboyd