Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to preshed v4 #875

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Switch to preshed v4 #875

wants to merge 1 commit into from

Conversation

adrianeboyd
Copy link
Contributor

Description

Switch to preshed v4.

Types of change

Enhancement?

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd adrianeboyd added the 🔜 v9.0 Related to upcoming v9.0 label Apr 28, 2023
@adrianeboyd adrianeboyd marked this pull request as draft April 28, 2023 12:30
@adrianeboyd
Copy link
Contributor Author

The idea here was to release the next version of thinc v9.0.0.devN so that we can use this in spacy v4, however preshed v4.0.0 seems to fail immediately in the tokenizer cache, so we'll put this on hold until we figure out what's going on.

@danieldk danieldk deleted the branch explosion:main April 19, 2024 11:50
@danieldk danieldk closed this Apr 19, 2024
@svlandeg svlandeg reopened this Apr 19, 2024
@svlandeg svlandeg changed the base branch from v9 to main April 19, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🔜 v9.0 Related to upcoming v9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrianeboyd @danieldk @svlandeg