Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addon module inserter gui #248

Merged
merged 7 commits into from
Sep 25, 2023
Merged

addon module inserter gui #248

merged 7 commits into from
Sep 25, 2023

Conversation

PHIDIAS0303
Copy link
Contributor

No description provided.

Cooldude2606
Cooldude2606 requested changes Sep 22, 2023
View reviewed changes
Copy link
Member

@Cooldude2606 Cooldude2606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes, only one breaking change with how you handle the gui element events.

modules/gui/module.lua Outdated Show resolved Hide resolved
modules/gui/module.lua Outdated Show resolved Hide resolved
modules/gui/module.lua Show resolved Hide resolved
modules/gui/module.lua Outdated Show resolved Hide resolved
config/module.lua Outdated Show resolved Hide resolved
Cooldude2606
Cooldude2606 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@Cooldude2606 Cooldude2606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes were made correctly, no conflicts after update to latest dev branch.

@Cooldude2606 Cooldude2606 merged commit 2eb8dc4 into explosivegaming:dev Sep 25, 2023
2 checks passed
@PHIDIAS0303 PHIDIAS0303 deleted the dev3 branch September 26, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cooldude2606 Cooldude2606 Cooldude2606 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PHIDIAS0303 @Cooldude2606