feat(adjust): add support for sdk signature #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
anyone have a chance to look at this? |
|
@youedd could you rebase your branch with latest main ? Also a nit pick fix is to correct the indentation that is being seen in your screenshots to make things look clean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
To implement Adjust SDK Signature, the Adjust team generates and provides two custom libraries that need to be integrated in the iOS and Android native projects.
This PR aims to add support for that.
How
if the sdk signature library path is specified:
iOS
Android
Test Plan
Tested locally on an existing project