[build-tools] Default missing outputs to empty string #500
+14
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
https://exponent-internal.slack.com/archives/C06EFBQK3B7/p1737419576613249
How
When we're collecting job outputs from steps, we treat values as strings which may include template expressions. So:
I see a way of reasoning about
outputs
that they are never expected to be used as static values, i.e.foo: bar
andkey: ios-${{ ... }}
are never what the user will want to use and instead we should always use value as an expression. However,looks strange to me.
We could also not stringify results and do what James suggests, let
undefined
beundefined
. However, that would also mean2
is2
, not"2"
. And I think it would be better for users that do want this level of type-correctness to explicitly docounter: ${{ toJSON(2) }}
and thenfromJSON(needs.setup.outputs.counter)
.Test Plan
Added test.