feat(eas-cli): Use a fallback generated name during EAS Submit #2842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +574 B (0%) Total Size: 53.4 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2842 +/- ##
==========================================
+ Coverage 52.62% 52.68% +0.07%
==========================================
Files 584 584
Lines 22638 22659 +21
Branches 4707 4716 +9
==========================================
+ Hits 11910 11935 +25
+ Misses 9800 9796 -4
Partials 928 928 ☔ View full report in Codecov by Sentry. |
|
✅ Thank you for adding the changelog entry! |
|
Subscribed to pull request
Generated by CodeMention |
szdziedzic
approved these changes
Jan 28, 2025
| }[]; | ||
| }; | ||
| } { | ||
| return 'data' in error && 'errors' in error.data && Array.isArray(error.data.errors); |
There was a problem hiding this comment.
We can try to validate this data against a scheme by using zod or joi instead of writing if statements manually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
If the name you selected was taken, it's a bit of a hassle to pick a new one. We had a fallback error message that said to use
--app-namebut this isn't a real flag afaict, and the fallback was never called!How
This change catches the duplicate name error and warns that a generated name will be used instead. This name can be instantly changed from the App Store Connect website later so it seems like a better default to ensure complex commands like
eas build --auto-submitare less prone to failure.Test Plan
Added some unit tests to emulate the responses of invalid fixtures.
Create a project with the name
expoRun
eas submitObserve a warning log like
App name "expo" is already taken. Using generated name "expo (6eb7d6)" which can be changed later from https://appstoreconnect.apple.com.Submit works as expected.
Name can be manually changed from the website.
Same process but with
expo🚀will warn:App name "expo🚀" contains invalid characters. Using sanitized name "expo-" which can be changed later from https://appstoreconnect.apple.com.