Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Skip non-exempt check in non-interactive mode. #2849

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Jan 30, 2025

Why

  • Skip the prompts if the user is running in CI or non-interactive.

How

How did you build this feature or fix this bug and why?

Test Plan

  • Tests keep working
  • eas build --non-interactive doesn't hang

Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Jan 30, 2025

Size Change: -1.37 kB (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB -1.37 kB (0%)

compressed-size-action

Copy link

✅ Thank you for adding the changelog entry!

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.54%. Comparing base (e0f6932) to head (7ac22e8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/eas-cli/src/project/ios/exemptEncryption.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2849      +/-   ##
==========================================
- Coverage   52.54%   52.54%   -0.00%     
==========================================
  Files         589      589              
  Lines       23036    23037       +1     
  Branches     4814     4814              
==========================================
  Hits        12103    12103              
- Misses       9970     9971       +1     
  Partials      963      963              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EvanBacon EvanBacon merged commit a85b9e2 into main Jan 30, 2025
10 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/cli/skip-non-exempt-check-in-CI branch January 30, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants