Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] add update support for fingerprint:compare #2850

Merged

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Jan 31, 2025

Why

Add support for comparing fingerprints between updates using the --update-id flag in the eas fingerprint compare command. This allows developers to compare fingerprints between updates, similar to how they can already compare fingerprints between builds.

How

  • Added updateId flag to the FingerprintCompare command
  • Extended the fingerprint comparison logic to handle updates as a fingerprint source
  • Added UpdateQuery.viewByUpdateAsync to fetch update details including fingerprint information
  • Updated the fingerprint origin type system to include updates as a source
  • Enhanced the pretty printing of fingerprint sources to show platform information for updates

Test Plan

  • EXPO_STAGING=1 ~/Documents/eas-cli/packages/eas-cli/bin/run fingerprint:compare --update-id 087ccb84-5b64-4285-aebf-e890cb95cd20

Copy link
Member Author

quinlanj commented Jan 31, 2025

Copy link

github-actions bot commented Jan 31, 2025

Size Change: +2.42 kB (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +2.42 kB (0%)

compressed-size-action

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 8.69565% with 21 lines in your changes missing coverage. Please review.

Project coverage is 52.52%. Comparing base (427c8f1) to head (c1ab6c1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/eas-cli/src/commands/fingerprint/compare.ts 10.00% 15 Missing and 3 partials ⚠️
...ackages/eas-cli/src/graphql/queries/UpdateQuery.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2850      +/-   ##
==========================================
- Coverage   52.54%   52.52%   -0.02%     
==========================================
  Files         589      589              
  Lines       23038    23054      +16     
  Branches     4815     4820       +5     
==========================================
+ Hits        12104    12106       +2     
- Misses       9971     9983      +12     
- Partials      963      965       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quinlanj quinlanj marked this pull request as ready for review January 31, 2025 02:02
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

@quinlanj quinlanj force-pushed the 01-30-_eas-cli_add_update_support_for_fingerprint_compare branch from 7d0d186 to c1ab6c1 Compare January 31, 2025 20:11
Copy link

✅ Thank you for adding the changelog entry!

@quinlanj quinlanj merged commit ebc277d into main Jan 31, 2025
11 checks passed
@quinlanj quinlanj deleted the 01-30-_eas-cli_add_update_support_for_fingerprint_compare branch January 31, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants