-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] change url in fingerprint:compare #2861
Merged
quinlanj
merged 4 commits into
main
from
02-03-_eas-cli_change_url_in_fingerprint_compare
Feb 4, 2025
Merged
[eas-cli] change url in fingerprint:compare #2861
quinlanj
merged 4 commits into
main
from
02-03-_eas-cli_change_url_in_fingerprint_compare
Feb 4, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +602 B (0%) Total Size: 53.4 MB
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2861 +/- ##
==========================================
- Coverage 52.33% 52.32% -0.01%
==========================================
Files 588 588
Lines 23137 23145 +8
Branches 4848 4849 +1
==========================================
+ Hits 12107 12108 +1
- Misses 10056 10062 +6
- Partials 974 975 +1 ☔ View full report in Codecov by Sentry. |
Subscribed to pull request
Generated by CodeMention |
wschurman
approved these changes
Feb 4, 2025
szdziedzic
approved these changes
Feb 4, 2025
✅ Thank you for adding the changelog entry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I'm in the process of changing the
fingerprint
path tofingerprints
in the website to be consistent with all our other routes here https://github.com/expo/universe/pull/18533This PR updates the URL to match the desired endpoint path on the Expo website.
How
Updated the URL path construction in the
FingerprintCompare
command to use the correct plural form/fingerprints/
instead of/fingerprint/
when generating the comparison URL.Test Plan
Ran
fingerprint:compare