[eas-cli] pass server env when resolving fingerprint runtime version #2867
+8
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
receiving an issue for a customer who uses eas environment and continuous-deploy-fingerprint github action. they have build variants setup in their app.config.ts. the app id, scheme and some other properties are determined by their
APP_VARIANT
variable. theAPP_VARIANT
is from eas server environment.when continuous-deploy-fingerprint first calculates fingerprint, it uses
eas env:exec
for thenpx expo-updates fingerprint:generate
call. theAPP_VARIANT
is correctly passed.then for
eas update
call, it doesn't pass theAPP_VARIANT
env and generates an inconsistent fingerprint.How
pass server env to the
getRuntimeVersionInfoObjectsAsync()
(npx expo-updates runtimeversion:resolve
)Test Plan
APP_VARIANT=staging
to my eas projectEXPO_DEBUG=1 eas update -m "update" --branch preview --environment production
to check theexpoConfig
fingerprint source of "android.package" isdev.expo.kudo.ooxx.staging
ordev.expo.kudo.ooxx.default'