-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature!: add support for eas cli installs #98
Conversation
b9aea5f
to
3d01cb4
Compare
BREAKING CHANGE: Github Action inputs are changed to allow both Expo and EAS CLI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar enough with the code to give you code-level review, but I tried this out in a project of mine and it worked well!
Here's my action for reference:
name: update
on:
push:
branches: [main]
jobs:
update:
name: Install and update
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 15.x
- uses: expo/expo-github-action@eas-support
with:
expo-version: latest
eas-version: latest
token: ${{ secrets.EXPO_TOKEN }}
expo-cache: true
eas-cache: true
- name: Find cache
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
- name: Restore cache
uses: actions/cache@v2
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn-
- run: yarn install
- run: eas branch:publish $(echo ${{ github.ref }} | sed 's_refs/heads/__') --message "${{ github.event.head_commit.message }}"
Nice, thanks for testing it! We should probably add some output helpers to get you of that ugly Also, random sidenote, I would stick with the even-numbered node versions. The uneven are more like experiments and will be EOL soon see releases |
* feature!: add support for eas cli installs * refactor: update the action metadata * docs: update documentation to include eas examples * fix: breaking change detection for semantic release * docs: add notion about latest eas version BREAKING CHANGE: Github Action inputs are changed to allow both Expo and EAS CLI.
## [6.0.0](5.5.1...6.0.0) (2021-06-22) ### ⚠ BREAKING CHANGES * Github Action inputs are changed to allow both Expo and EAS CLI. ### New features * add support for eas cli installs ([#98](#98)) ([04692c3](04692c3)) ### Other chores * update node to 14 and 16 in ci ([#100](#100)) ([a03876e](a03876e)) ### Documentation changes * add commands to contirbuting guide for updating v{major} tags ([1b57c37](1b57c37)) * update readme for v6 release ([#101](#101)) ([8b43bae](8b43bae)) * update upstream reference in contributing guide ([76ce4de](76ce4de))
BREAKING CHANGE: Github Action inputs are changed to allow both Expo and EAS CLI.
Part of #97