This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
Fixes to make ExpoPixi.Signature work on web #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing the ref prop access on the web platform cf github issue expo/expo#10774 cf Github issue expo#72
To circumvent ../utils not finding it cf Github issue expo#72
|
Hello 👋 It's been almost a year since I pushed that PR and that I'm running a fork of expo-pixi. Is there someone left to maintain this code base ? 🤔 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getContextAttributesfrom context on web platform cf Issue when running Signature on Expo Web #147refassignment for GLView. There's an issue opened on expo-gl, because I believe it should be fixed there, not here. cf ExpoGL on the Web: crash because of ref prop on GLView expo#10774.takeSnapshotAsync()call for the web platform by using the static call. I'm not sure why the local utils one is actually failing to call the bound one.About 3. I did not make an issue, because even though the
takeSnapshotAsynccall works, it only saves blank images. I need to figure out why (maybe I'm giving it a wrong context? 🤔 )This could be three distinct one commit PR, though I believe they all belong together as it's achieving one goal: make Signature work on the web :)