Upgrade roboletric and junit versions to be consistent #22395
Conversation
josephyanks
requested review from
ide,
tsapeta,
brentvatne,
wschurman,
douglowder,
Kudo,
lukmccall,
EvanBacon and
aleqsio
as code owners
expo-bot
added
bot: passed checks
|
@Kudo I'm not sure how much I need to worry about these other CI steps failing - it seems like every time they run they fail for a different reason. I've verified that the android unit tests pass locally, and can't get the android instrumentation tests to run. Let me know what needs to be done to get this merged, thanks! |
|
@josephyanks don't worry for that. some failures are intentional. i'm sorry that our ci tests are not friendly for external contributors. i will take care of it, either merge it or let you know if there are any real issues we need to update. thanks! |
|
@Kudo no worries, just want to make sure I'm being thorough! it should be good to merge once I get the approval then |
| // Note that on some tests, the pixel value will be -16777216, which is | ||
| // 11111111 00000000 00000000 00000000 in binary form. This is also a fully-opaque | ||
| // black color, so comparing hex strings is cleaner to capture both acceptable results | ||
| // (0 and -16777216). |
There was a problem hiding this comment.
i love this comment. it makes things so clear. thanks for adding this.
There was a problem hiding this comment.
last thing before approving and merging. i think updating bundles inside expo-dev-launcher are unrelated to this pr. i know that this might to resolve ci issues, but don't worry i'll try to fix ci issues in a separated pr. please help to revert the expo-dev-launcher bundles changes. thank you!
|
@Kudo Those two bundle updates from |
Why
The bumping of robolectric to 4.10 means that we no longer need jetifier to translate old support library dependencies.
How
robolectricto4.10andjunitto4.13.2expo-modules-test-coreto their latest versionsexpo-clipboardtest because of changes to the way that robolectric handles decoding bitmaps for tests.Test Plan
Ensured unit tests still pass
Trying to verify end to end tests locally.
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).