[packages] fix react-native 0.73 compatibility [1/3] #24018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: passed checks
Kudo
changed the title
Kudo
requested review from
ide,
tsapeta,
brentvatne,
wschurman,
douglowder,
byCedric,
EvanBacon,
lukmccall and
aleqsio
as code owners
Kudo
removed request for
brentvatne,
wschurman,
ide,
byCedric,
tsapeta,
aleqsio,
douglowder and
EvanBacon
tsapeta
approved these changes
Aug 18, 2023
EvanBacon
pushed a commit
that referenced
this pull request
Aug 23, 2023
# Why fix react-native 0.73 compatibility. these are for AGP 8 support - react-native-community/discussions-and-proposals#671 (comment) # How - [packages][bare-expo] set jvm version only if AGP < 8 - [av][dev-launcher] fix AGP 8 non transitive R issue - [dev-client][dev-launcher][dev-menu][core][notifications] fix AGP 8 non default buildConfig issue # Test Plan ci passed in #23961 (https://github.com/expo/expo/pull/23961/checks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
fix react-native 0.73 compatibility. these are for AGP 8 support - react-native-community/discussions-and-proposals#671 (comment)
How
Test Plan
ci passed in #23961 (https://github.com/expo/expo/pull/23961/checks)
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).