[localization] Add default temperature unit to the locale #24059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behenate
requested review from
Simek,
amandeepmittal,
EvanBacon and
aleqsio
as code owners
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
lukmccall
approved these changes
Aug 22, 2023
packages/expo-localization/android/src/main/java/expo/modules/localization/LocalizationUtils.kt
Outdated
Show resolved
Hide resolved
aleqsio
approved these changes
Aug 22, 2023
amandeepmittal
approved these changes
Aug 22, 2023
tsapeta
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We want to add a temperature unit field which will return the temperature unit used in the region
ENG-6859
How
On iOS the unit is based on the current settings in the region tab of the settings app (note: settings values are ignored in iOS simulator so any testing in the future should be done on a physical device)
On Android and web a list of regions which use fahrenheit is used and compared with the current device region.
Test Plan
Tested in Bare Expo on Android 13, iOS 16 and web