fix(asset): URL encode asset paths defined as query parameter #24562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byCedric
force-pushed
the
@bycedric/asset/escape-path-when-hashing-assets
branch
from
21cfe5c to
3668954
Compare
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
byCedric
added a commit
to byCedric/expo-50-pnpm
that referenced
this pull request
Sep 21, 2023
tsapeta
approved these changes
Sep 22, 2023
| const assetPathQueryParameter = asset.httpServerLocation.match( | ||
| /\?(export_path|unstable_path)=(.*)/ | ||
| ); | ||
| if (assetPathQueryParameter && assetPathQueryParameter[2]) { |
There was a problem hiding this comment.
nit: this could look a bit better with 👇
Suggested change
| if (assetPathQueryParameter && assetPathQueryParameter[2]) { | |
| if (assetPathQueryParameter?.[2]) { |
There was a problem hiding this comment.
Yeah, I wasn't sure if we could use that since this file is NOT being transpiled. It's just a plain JS file being shipped as is, so I also avoided constructor magic 🙈
byCedric
deleted the
@bycedric/asset/escape-path-when-hashing-assets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Package folders may contain a
+symbol when using isolated modules by supported package managers. This happens for@expo/vector-iconsand pnpm, for example:While the path is valid, the
+is interpreted as a special character (space) because it's not URL encoded.How
asset.httpServerLocation) when defined as ?export_pathor?unstable_path` query parameter.Test Plan
require.resolve#24561)$ pnpm expo startChecklist
npx expo prebuild& EAS Build (eg: updated a module plugin).