Keep upstream additionalExts when adding env files #24809
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinusU
requested review from
EvanBacon,
byCedric and
marklawlor
as code owners
expo-bot
added
bot: passed checks
EvanBacon
reviewed
Oct 11, 2023
| @@ -146,7 +143,7 @@ export function getDefaultConfig( | |||
| }, | |||
| watcher: { | |||
| // strip starting dot from env files | |||
| additionalExts: envFiles.map((file: string) => file.replace(/^\./, '')), | |||
| additionalExts: ['cjs', 'mjs', ...envFiles.map((file: string) => file.replace(/^\./, ''))], | |||
There was a problem hiding this comment.
This would land in SDK 50, where mjs support is already enabled in a more robust way. Backporting would potentially break existing projects due to facebook/react-native#38628
There was a problem hiding this comment.
The change also doesn't account for Node.js file handling which requires some reordering. Unclear to me which version of React Native the Metro change was meant to support.
EvanBacon
requested changes
Oct 11, 2023
|
Closing since SDK 50 is out now, and shouldn't need this 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In React Native 0.72
additionalExtsis set to['.cjs', '.mjs']for out of the box support for these extensions, see facebook/metro@c1c6d9c. Because of this being overridden here.mjssupport doesn't seem to be working out-of-the-box.More info:
How
This change makes sure to keep the
additionalExtsthat are set in React Native, in addition to the env-files that are added by Expo.Test Plan
Not sure how to best test this. As described in #23322 overriding
additionalExtsin my own metro config fixes the problem. I'm very open to suggestions here!Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).