fix: provide more image metadata in image-picker #29648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vonovak
commented
Jun 11, 2024
| @@ -10,7 +10,7 @@ | |||
| "test:ios": "export NODE_ENV=\"test\" && ./scripts/start-simulator.sh", | |||
| "test:android": "export NODE_ENV=\"test\" && ./scripts/start-emulator.sh", | |||
| "edit:android": "open -a /Applications/Android\\ Studio.app ./android", | |||
| "edit:ios": "open -a Xcode ./ios/BareExpo.xcworkspace", | |||
| "edit:ios": "xed ./ios/BareExpo.xcworkspace", | |||
There was a problem hiding this comment.
this should be more robust: because I don't have Xcode.app in applications (I have Xcode15_2 and Xcode15_3), this command failed. xed works for me. https://www.unix.com/man-page/osx/1/xed/
vonovak
commented
Jun 11, 2024
| @@ -143,9 +143,7 @@ public class ImagePickerModule: Module, OnMediaPickingResultHandler { | |||
| // selection limit = 1 --> single selection, reflects the old picker behavior | |||
| configuration.selectionLimit = options.allowsMultipleSelection ? options.selectionLimit : SINGLE_SELECTION | |||
| configuration.filter = options.mediaTypes.toPickerFilter() | |||
| if #available(iOS 14, *) { | |||
There was a problem hiding this comment.
the whole fn is wrapped in @available(iOS 14, *) already (line 138)
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
|
It would be lovely if the same functionality could be added for the Expo documents picker. They have overlapping functionality, just different picker locations. |
alanjhughes
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
closes #29442 by adding extra metadata to the result of
ImagePicker.launchImageLibraryAsync.Generally speaking, with these apis, it's easy to miss this or that piece of information because the information is scattered across various places, and there are even manufacturer-specific ones, such as for Minolta, Canon and others.
However, I believe the TIFF information should be commonly present and also brings the result closer to Android.
How
I'm taking metadata from
kCGImagePropertyTIFFDictionaryand merging it with the existingexifdictionary. In case of duplicate keys, the exif value is preserved.I removed usage of
kCGImagePropertyOrientationbecause the value, if present, is the same as the value in TIFF metadata source. The key is the same as well, though this is not confirmed by any docs.Test Plan
Tested on simulator and device
Checklist
No need to update docs, and the rest doesn't apply imo
npx expo prebuild& EAS Build (eg: updated a module plugin).