Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix ExpoRequestInterceptorProtocol leakage #29798

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Jun 16, 2024

Why

fixes #29561

How

create a shared URLSession to prevent memory leak

Test Plan

test network inspector in bare-expo

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jun 16, 2024
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jun 16, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented Jun 16, 2024

The Pull Request introduced fingerprint changes against the base commit: 5ebe039

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "../../packages/expo-modules-core",
    "reasons": [
      "expoAutolinkingIos",
      "expoAutolinkingAndroid"
    ],
    "hash": "34ed95b8d64dab36cfdabc9219ea309363e421a0"
  }
]

Generated by PR labeler 🤖

@expo-bot expo-bot added bot: suggestions ExpoBot has some suggestions bot: passed checks ExpoBot has nothing to complain about and removed bot: passed checks ExpoBot has nothing to complain about bot: suggestions ExpoBot has some suggestions labels Jun 17, 2024
@Kudo Kudo force-pushed the @kudo/fix-ExpoRequestInterceptorProtocol-leak branch from 5bcb4bb to 7095f9c Compare June 17, 2024 12:50
@Kudo Kudo marked this pull request as ready for review June 17, 2024 14:22
@Kudo Kudo requested review from tsapeta and lukmccall as code owners June 17, 2024 14:22
@Kudo Kudo merged commit 1420937 into main Jun 18, 2024
11 checks passed
@Kudo Kudo deleted the @kudo/fix-ExpoRequestInterceptorProtocol-leak branch June 18, 2024 16:35
Kudo added a commit that referenced this pull request Jun 20, 2024
fixes #29561

create a shared `URLSession` to prevent memory leak

(cherry picked from commit 1420937)
@tsapeta tsapeta added the published Changes from the PR have been published to npm label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
4 participants