Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][av] fix error on new architecture mode #30030

Merged
merged 6 commits into from
Jun 27, 2024
Merged

[core][av] fix error on new architecture mode #30030

merged 6 commits into from
Jun 27, 2024

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Jun 26, 2024

Why

fixes #29996

How

it's a regression from #28829

  • [core] fix addUIBlock and executeUIBlock crash on new architecture mode. we don't have to access content subview after my changes.
  • [av] Video is broken because the legacy EXVideoView is not an ExpoFabricView and doesn't receive prop updates. it was working because we had the view wrapper. this pr tries to add an ExpoVideoView to contain the subview. that is to simulate the working state before my change

Test Plan

  • bare-expo video test
  • fabric-tester video test

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jun 26, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented Jun 26, 2024

The Pull Request introduced fingerprint changes against the base commit: e3b9790

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "../../packages/expo-av/ios",
    "reasons": [
      "expoAutolinkingIos"
    ],
    "hash": "5211595e6d8409bd7ca70c3b0e833dd7bd95975d"
  },
  {
    "type": "dir",
    "filePath": "../../packages/expo-modules-core",
    "reasons": [
      "expoAutolinkingIos",
      "expoAutolinkingAndroid"
    ],
    "hash": "9f81b81d93f522d385efb5f3ef11a62ae97e1abb"
  }
]

Generated by PR labeler 🤖

@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jun 26, 2024
@Kudo Kudo marked this pull request as ready for review June 27, 2024 06:01
@Kudo Kudo requested review from tsapeta and lukmccall as code owners June 27, 2024 06:01
@Kudo Kudo merged commit 07786f3 into main Jun 27, 2024
11 checks passed
@Kudo Kudo deleted the @kudo/fix-29996 branch June 27, 2024 18:34
Kudo added a commit that referenced this pull request Jun 27, 2024
fixes #29996

it's a regression from #28829

- [core] fix `addUIBlock` and `executeUIBlock` crash on new architecture
mode. we don't have to access content subview after my changes.
- [av] Video is broken because the legacy `EXVideoView` is not an
ExpoFabricView and doesn't receive prop updates. it was working because
we had the view wrapper. this pr tries to add an `ExpoVideoView` to
contain the subview. that is to simulate the working state before my
change

(cherry picked from commit 07786f3)
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[expo-av] Crash when playing video on new arch
5 participants