-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core][av] fix error on new architecture mode #30030
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Pull Request introduced fingerprint changes against the base commit: e3b9790 Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-av/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "5211595e6d8409bd7ca70c3b0e833dd7bd95975d"
},
{
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "9f81b81d93f522d385efb5f3ef11a62ae97e1abb"
}
] Generated by PR labeler 🤖 |
expo-bot
added
bot: passed checks
ExpoBot has nothing to complain about
and removed
bot: suggestions
ExpoBot has some suggestions
labels
Jun 26, 2024
lukmccall
approved these changes
Jun 27, 2024
tsapeta
approved these changes
Jun 27, 2024
Kudo
added a commit
that referenced
this pull request
Jun 27, 2024
fixes #29996 it's a regression from #28829 - [core] fix `addUIBlock` and `executeUIBlock` crash on new architecture mode. we don't have to access content subview after my changes. - [av] Video is broken because the legacy `EXVideoView` is not an ExpoFabricView and doesn't receive prop updates. it was working because we had the view wrapper. this pr tries to add an `ExpoVideoView` to contain the subview. that is to simulate the working state before my change (cherry picked from commit 07786f3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bot: fingerprint changed
bot: passed checks
ExpoBot has nothing to complain about
published
Changes from the PR have been published to npm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
fixes #29996
How
it's a regression from #28829
addUIBlock
andexecuteUIBlock
crash on new architecture mode. we don't have to access content subview after my changes.EXVideoView
is not an ExpoFabricView and doesn't receive prop updates. it was working because we had the view wrapper. this pr tries to add anExpoVideoView
to contain the subview. that is to simulate the working state before my changeTest Plan
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).