Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[network][Android] Fix NetworkCallback was not registered #30185

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

lukmccall
Copy link
Contributor

Why

Fixes java.lang.IllegalArgumentException: NetworkCallback was not registered

Test Plan

  • bare-expo ✅

@lukmccall lukmccall requested review from Kudo and aleqsio July 4, 2024 12:03
@lukmccall lukmccall requested a review from ide as a code owner July 4, 2024 12:03
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jul 4, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented Jul 4, 2024

The Pull Request introduced fingerprint changes against the base commit: 7206802

Fingerprint diff
[
  {
    "op": "changed",
    "source": {
      "type": "dir",
      "filePath": "../../packages/expo-network/android",
      "reasons": [
        "expoAutolinkingAndroid"
      ],
      "hash": "eb90885f3e72592f71953477e235ee191d3ef570"
    }
  }
]

Generated by PR labeler 🤖

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@lukmccall lukmccall merged commit acb2243 into main Jul 4, 2024
1 check passed
@lukmccall lukmccall deleted the @lukmccall/network/fix-callback-not-registered branch July 4, 2024 14:00
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants