Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump kotlin version to 1.9.24 #30199

Merged
merged 3 commits into from
Jul 7, 2024

Conversation

gabrieldonadel
Copy link
Member

@gabrieldonadel gabrieldonadel commented Jul 4, 2024

Why

React-native 0.75 bumps kotlinVersion 1.9.24, it should be good for us to align the kotlin version.

Related to ENG-12562

How

Test Plan

ci passed

Checklist

Copy link

linear bot commented Jul 4, 2024

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jul 4, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented Jul 4, 2024

The Pull Request introduced fingerprint changes against the base commit: baa2c53

Fingerprint diff
[
  {
    "op": "changed",
    "source": {
      "type": "dir",
      "filePath": "../../packages/expo-dev-launcher",
      "reasons": [
        "expoAutolinkingIos",
        "expoAutolinkingAndroid"
      ],
      "hash": "0926b8f20b942e50c8c16e7da3cd19265a0b54e7"
    }
  },
  {
    "op": "changed",
    "source": {
      "type": "dir",
      "filePath": "../../packages/expo-dev-launcher/expo-dev-launcher-gradle-plugin",
      "reasons": [
        "expoAutolinkingAndroid"
      ],
      "hash": "2485ed4c439e577c54fe82e209bcf7c1ba5f165e"
    }
  },
  {
    "op": "changed",
    "source": {
      "type": "dir",
      "filePath": "../../packages/expo-modules-core",
      "reasons": [
        "expoAutolinkingIos",
        "expoAutolinkingAndroid"
      ],
      "hash": "9f90eedc590ceb0cdf00403990cfb6695f4d72cb"
    }
  },
  {
    "op": "changed",
    "source": {
      "type": "dir",
      "filePath": "../../packages/expo-network-addons/expo-network-addons-gradle-plugin",
      "reasons": [
        "expoAutolinkingAndroid"
      ],
      "hash": "b7e321577afe4449f5574601d260bfaddea01104"
    }
  },
  {
    "op": "changed",
    "source": {
      "type": "dir",
      "filePath": "../../packages/expo-updates/expo-updates-gradle-plugin",
      "reasons": [
        "expoAutolinkingAndroid"
      ],
      "hash": "0250a9961c3da8ddf3f456b4b8b7c1f8745868cb"
    }
  },
  {
    "op": "changed",
    "source": {
      "type": "dir",
      "filePath": "android",
      "reasons": [
        "bareNativeDir"
      ],
      "hash": "7c79a4b7200c7ee0e276df6a2abe92413545a910"
    }
  }
]

Generated by PR labeler 🤖

@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/upgrade-react-native-0-75-0 branch 3 times, most recently from c8a35ce to 804d029 Compare July 5, 2024 12:19
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jul 5, 2024
@gabrieldonadel gabrieldonadel marked this pull request as ready for review July 5, 2024 12:27
@Kudo
Copy link
Contributor

Kudo commented Jul 5, 2024

we may need to update the ksp version here

@gabrieldonadel
Copy link
Member Author

gabrieldonadel commented Jul 5, 2024

we may need to update the ksp version here

The problem is that when I try to use 1.9.24-1.0.20 it leads to the following internal compiler error. Any ideas of what could cause this? Found this simular report here google/ksp#1733

Task :expo-updates:kspDebugKotlin FAILED
e: java.lang.NoSuchMethodError: 'void org.jetbrains.kotlin.incremental.IncrementalCompilationContext.(org.jetbrains.kotlin.incremental.storage.FileToPathConverter, org.jetbrains.kotlin.incremental.storage.FileToPathConverter, boolean, org.jetbrains.kotlin.incremental.CompilationTransaction, org.jetbrains.kotlin.build.report.ICReporter, boolean, boolean, boolean, int, kotlin.jvm.internal.DefaultConstructorMarker)'

Would it be okay for us to use "1.9.24": "1.9.23-1.0.20"?

@wschurman wschurman removed their request for review July 5, 2024 16:51
@Kudo
Copy link
Contributor

Kudo commented Jul 5, 2024

Would it be okay for us to use "1.9.24": "1.9.23-1.0.20"?

i don't have much expertise in ksp. maybe @lukmccall has more experience?

@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/upgrade-react-native-0-75-0 branch from efab497 to 067f88c Compare July 6, 2024 19:02
@lukmccall
Copy link
Contributor

Would it be okay for us to use "1.9.24": "1.9.23-1.0.20"?

So generally, we should use version 1.9.24-*, but 1.9.23 should work fine for now. Let's stick to the version that actually works.

@gabrieldonadel gabrieldonadel merged commit 502086d into main Jul 7, 2024
15 of 17 checks passed
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/upgrade-react-native-0-75-0 branch July 7, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants