-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Removed all NativeModulesProxy
occurrences
#31496
Conversation
NativeModulesProxy
occurrencesNativeModulesProxy
occurrences
561e4bb
to
6e2306c
Compare
# Conflicts: # packages/expo-modules-core/CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you so much! 🙏 I left some changelog suggestions, but in general it looks good.
Recently I had some troubles to move off of NativeModulesProxy
in expo-font
tests, but looks like they are passing now – which is great 👍
Co-authored-by: Tomasz Sapeta <tomasz.sapeta@me.com>
Co-authored-by: Tomasz Sapeta <tomasz.sapeta@me.com>
Co-authored-by: Tomasz Sapeta <tomasz.sapeta@me.com>
Co-authored-by: Tomasz Sapeta <tomasz.sapeta@me.com>
Co-authored-by: Tomasz Sapeta <tomasz.sapeta@me.com>
Co-authored-by: Tomasz Sapeta <tomasz.sapeta@me.com>
Co-authored-by: Tomasz Sapeta <tomasz.sapeta@me.com>
You're welcome 🙏 |
Yeah, I think it's too early. We'll probably need to search over GitHub to see if there are any popular libraries importing it and help them migrate. I would keep it until we entirely remove the legacy modules from the native code. One more thing we could do is to make it a |
Why
In order to remove
NativeModulesProxy
fromexpo-modules-core
in the future, I have replaced the use of it in all other packages.How
I have replaced all occurrences of the deprecated
NativeModulesProxy
.I have left the export of
NativeModulesProxy
in theindex.ts
ofexpo-modules-core
, but can remove it if it is not too early.Test Plan
Test cases run.
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).