[core][Android] Rename SharedObject.deallocate to SharedObject.sharedObjectDidRelease
#31921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The Pull Request introduced fingerprint changes against the base commit: c3c7fa6 Fingerprint diff[
{
"op": "changed",
"source": {
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "d655f749eac5563e190b14ccbd931420a42d8c11"
}
}
]Generated by PR labeler 🤖 |
tsapeta
requested changes
Oct 8, 2024
...es/expo-modules-core/android/src/main/java/expo/modules/kotlin/sharedobjects/SharedObject.kt
Outdated
Show resolved
Hide resolved
...es/expo-modules-core/android/src/main/java/expo/modules/kotlin/sharedobjects/SharedObject.kt
Outdated
Show resolved
Hide resolved
...modules-core/android/src/main/java/expo/modules/kotlin/sharedobjects/SharedObjectRegistry.kt
Outdated
Show resolved
Hide resolved
lukmccall
changed the title
SharedObject.deallocate to SharedObject.wasReleasedSharedObject.deallocate to SharedObject.sharedObjectDidRelease
Kudo
approved these changes
Oct 8, 2024
tsapeta
approved these changes
Oct 8, 2024
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
lukmccall
deleted the
@lukmccall/core/rename-deallocate-to-was-released
branch
expo-bot
added
bot: passed checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Renames
SharedObject.deallocatetoSharedObject.sharedObjectDidReleaseI think it's a more suitable name for this function.