Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] add docs links to Record implementations #31997

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

vonovak
Copy link
Contributor

@vonovak vonovak commented Oct 11, 2024

Why

As a developer, it'd be nice to have some help for when I cmd+click on our Record / Field annotations.

How

Added comments with links to the Expo documentation page that lists supported argument types for modules. These comments were inserted in the following files:

  • Field.kt and Record.kt for Android
  • Field.swift and Record.swift for iOS

Test Plan

Checklist

Copy link
Contributor Author

vonovak commented Oct 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @vonovak and the rest of your teammates on Graphite Graphite

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Oct 11, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented Oct 11, 2024

The Pull Request introduced fingerprint changes against the base commit: 4bfca2d

Fingerprint diff
[
  {
    "op": "changed",
    "source": {
      "type": "dir",
      "filePath": "../../packages/expo-modules-core",
      "reasons": [
        "expoAutolinkingIos",
        "expoAutolinkingAndroid"
      ],
      "hash": "4f2c37107e75df8f6af9f1b375b4038d3e13722e"
    }
  }
]

Generated by PR labeler 🤖

@vonovak vonovak marked this pull request as ready for review October 11, 2024 14:29
Copy link
Contributor

Subscribed to pull request

File Patterns Mentions
packages/expo-modules-core/** @tsapeta, @Kudo, @lukmccall

Generated by CodeMention

@vonovak vonovak force-pushed the @vonovak/_core_add_docs_links_to_record_implementations branch from 0881f8a to f2baa92 Compare October 11, 2024 14:32
@vonovak vonovak requested review from tsapeta and lukmccall October 11, 2024 14:32
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Oct 11, 2024
packages/expo-modules-core/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Kudo Chien <kudo@expo.dev>
@vonovak vonovak merged commit 675ec88 into main Oct 11, 2024
14 checks passed
@vonovak vonovak deleted the @vonovak/_core_add_docs_links_to_record_implementations branch October 11, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants