Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[notifications] warn when using push tokens in Expo Go #32122

Merged

Conversation

vonovak
Copy link
Contributor

@vonovak vonovak commented Oct 17, 2024

Why

We'll be removing push notifications from Expo Go in SDK 53, so we're giving a heads-up warning in SDK 52

How

add a non-spammy warning

Test Plan

tested locally, shows a warning in the devtools

Checklist

Copy link
Contributor Author

vonovak commented Oct 17, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @vonovak and the rest of your teammates on Graphite Graphite

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Oct 17, 2024
@vonovak vonovak force-pushed the @vonovak/_notifications_warn_when_using_push_tokens_in_expo_go branch from 954a9c4 to 79a14ba Compare October 17, 2024 15:08
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Oct 17, 2024
@vonovak vonovak force-pushed the @vonovak/_notifications_warn_when_using_push_tokens_in_expo_go branch from 79a14ba to ffc77cf Compare October 21, 2024 08:09
@vonovak vonovak force-pushed the @vonovak/_notifications_warn_when_using_push_tokens_in_expo_go branch from ffc77cf to 3f13681 Compare October 21, 2024 13:13
@vonovak vonovak requested a review from douglowder October 21, 2024 13:13
@vonovak vonovak marked this pull request as ready for review October 21, 2024 13:13
Copy link
Contributor

Subscribed to pull request

File Patterns Mentions
packages/expo-notifications/** @douglowder, @tsapeta

Generated by CodeMention

@vonovak vonovak merged commit ddea762 into main Oct 23, 2024
11 checks passed
@vonovak vonovak deleted the @vonovak/_notifications_warn_when_using_push_tokens_in_expo_go branch October 23, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants