[expo-file-system] Add support for ph:// scheme in FileSystem #5195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbarthec
approved these changes
Aug 6, 2019
sjchmiela
force-pushed
the
@sjchmiela/add_support_for_ph_in_file_system
branch
from
2e136a7 to
918e5d9
Compare
sjchmiela
added a commit
that referenced
this pull request
Aug 6, 2019
# Why Should fix #4995. # How Added support for `ph://` scheme in FileSystem. # Test Plan With this change running ```js CameraRoll.getPhotos({ first: 10, assetType: 'All', }).then(({ edges }) => FileSystem.getInfoAsync(edges[0].node.image.uri).then(console.log)); ``` rendered ``` Object { "exists": true, "isDirectory": false, "modificationTime": 1526314683.382386, "uri": null, } ``` instead of ``` [Unhandled promise rejection: Error: File 'ph://4607021A-7369-459C-881D-277E6612A4E7/L0/001' isn't readable.] ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Should fix #4995.
How
Added support for
ph://scheme in FileSystem.Test Plan
With this change running
rendered
instead of