Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add peer dependency on expo #286

Merged
merged 3 commits into from
Oct 4, 2022
Merged

fix: add peer dependency on expo #286

merged 3 commits into from
Oct 4, 2022

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Sep 15, 2022

Checklist

Why

Without this, the following warnings are printed when running yarn in this repo

warning " > expo-updates@0.14.3" has unmet peer dependency "expo@*".
warning "expo-updates > expo-updates-interface@0.7.0" has unmet peer dependency "expo@*".

How

Just updated package.json and ran yarn

Test Plan

🤷

@kbrandwijk
Copy link
Contributor

expo is already in the devDependencies as well, so this seems to be more of a yarn quirk than anything else.

@SimenB
Copy link
Contributor Author

SimenB commented Sep 16, 2022 •
edited
Loading

expo is already in the devDependencies

It's not - I added it in this PR

@kbrandwijk
Copy link
Contributor

expo is already in the devDependencies

It's not - I added it in this PR

My bad. I'll run some tests and get this in.

@SimenB
Copy link
Contributor Author

SimenB commented Oct 4, 2022

Ping @kbrandwijk 🙂

@kbrandwijk kbrandwijk merged commit 8f78e0f into expo:main Oct 4, 2022
@kbrandwijk
Copy link
Contributor

I'll push a release soon.

@SimenB SimenB deleted the add-expo-peer-dep branch October 4, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimenB @kbrandwijk