fix: only create bundle & map files for the specified platform when uploading sourcemaps #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danshilm
force-pushed
the
fix/upload-sourcemaps-hook
branch
from
6f6fca8
to
4acb961
Compare
chore: add entry to changelog chore: run yarn build
danshilm
force-pushed
the
fix/upload-sourcemaps-hook
branch
from
4acb961
to
6768c93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Why
While the current hook works just fine, attempting to manually execute it when the sourcemaps for only one platform have been dumped & are being used in the hook, results in an error when trying to write the bundle & map files for the other platform.
How
Check which platform has been specified for the hook before writing bundle & map files.
Test Plan
Tested by running the hook manually.