fix(rn-options): Create new options object on every init to avoid read only error when initializing multiple times #350
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Why
sdk
with the value #347How
Because of the use of
const DEFAULT_OPTIONS
the options key_metadata
was shared between multiple instances of Sentry when initialized twice in the same runtime, since Sentry saves default values to the_metadata
and later on makes theoptions
read-only the assign would fail the second time.Test Plan
Sentry.init({...});
Sentry.init({...});
I've simulated the error by running the
init
multiple times, tho this should not ever be done in a real App. But it happens during the JS reload when the environment stays for example during OTA updates.