chore: upgrade tooling to latest versions (#212)

* chore: upgrade to Node 18 and typescript 5 * chore: upgrade semantic release and conventional commits * chore: upgrade eslint and prettier * chore: upgrade vsce and osvx * chore: upgrade vscode telemetry * refactor: update code for new vscode telemetry * chore: remove unused `parent-module` package * chore: upgrade webpack cli
expo · Aug 31, 2023 · 0324b10 · 0324b10
1 parent 602946c
commit 0324b10
Show file tree

Hide file tree

Showing 9 changed files with 4,042 additions and 1,701 deletions.
diff --git a/.github/actions/setup-project/action.yml b/.github/actions/setup-project/action.yml
@@ -4,7 +4,7 @@ description: Prepare the project for any CI action
 inputs:
   node-version:
     description: Version of Node to install
-    default: 16.x
+    default: 18.x
 
   with-fixture:
     description: If the setup should install the test/fixture files

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -42,30 +42,28 @@
     "@expo/config-plugins": "^4.1.5",
     "@expo/json-file": "^8.2.36",
     "@expo/prebuild-config": "^4.0.3",
-    "@semantic-release/changelog": "^6.0.1",
+    "@semantic-release/changelog": "^6.0.3",
     "@semantic-release/git": "^10.0.1",
     "@sucrase/webpack-loader": "^2.0.0",
-    "@tsconfig/node16": "^1.0.3",
+    "@tsconfig/node18": "^18.2.1",
     "@types/chai": "^4.3.5",
     "@types/chai-subset": "^1.3.3",
     "@types/debug": "^4.1.7",
     "@types/minimatch": "^3.0.5",
     "@types/mocha": "^10.0.1",
-    "@types/node": "^16.11.56",
+    "@types/node": "^18.17.12",
     "@types/node-fetch": "^2.6.2",
     "@types/vscode": "^1.78.2",
-    "@typescript-eslint/eslint-plugin": "^5.48.0",
-    "@typescript-eslint/parser": "^5.48.0",
-    "@vscode/extension-telemetry": "^0.7.7",
+    "@vscode/extension-telemetry": "^0.8.4",
     "@vscode/test-electron": "^2.3.2",
-    "@vscode/vsce": "^2.16.0",
+    "@vscode/vsce": "^2.21.0",
     "arg": "^5.0.2",
     "chai": "^4.3.8",
     "chai-subset": "^1.6.0",
-    "conventional-changelog-conventionalcommits": "^5.0.0",
+    "conventional-changelog-conventionalcommits": "^7.0.1",
     "debug": "^4.3.4",
-    "eslint": "^8.31.0",
-    "eslint-config-universe": "^11.1.1",
+    "eslint": "^8.48.0",
+    "eslint-config-universe": "^12.0.0",
     "execa": "^5.1.1",
     "find-up": "^5.0.0",
     "glob": "^10.3.3",
@@ -76,17 +74,16 @@
     "mocha": "^10.2.0",
     "mocha-chai-jest-snapshot": "^1.1.4",
     "node-fetch": "^2.6.7",
-    "ovsx": "^0.8.0",
-    "parent-module": "^2.0.0",
+    "ovsx": "^0.8.3",
     "patch-package": "^6.4.7",
-    "prettier": "^2.8.1",
+    "prettier": "^3.0.3",
     "raw-loader": "^4.0.2",
-    "semantic-release": "^19.0.3",
+    "semantic-release": "^21.1.1",
     "semver": "^7.5.2",
     "sucrase": "^3.20.3",
-    "typescript": "^4.9.4",
+    "typescript": "^5.2.2",
     "webpack": "^5.76.0",
-    "webpack-cli": "^4.7.0"
+    "webpack-cli": "^5.1.4"
   },
   "publisher": "expo",
   "icon": "images/logo-marketplace.png",

diff --git a/src/__tests__/commands/code-provider.e2e.ts b/src/__tests__/commands/code-provider.e2e.ts
@@ -42,8 +42,8 @@ describe('CodeProvider', () => {
     await replaceEditorContent(app, json.applyEdits(app.document.getText(), addition));
     await app.document.save();
 
-    const includesChange = await waitForTrue(() =>
-      preview?.document.getText().includes('android.permission.CAMERA')
+    const includesChange = await waitForTrue(
+      () => preview?.document.getText().includes('android.permission.CAMERA')
     );
 
     expect(includesChange).to.equal(true);
@@ -58,8 +58,8 @@ describe('CodeProvider', () => {
     await replaceEditorContent(app, json.applyEdits(app.document.getText(), removal));
     await app.document.save();
 
-    const excludesChange = await waitForFalse(() =>
-      preview?.document.getText().includes('android.permission.CAMERA')
+    const excludesChange = await waitForFalse(
+      () => preview?.document.getText().includes('android.permission.CAMERA')
     );
 
     expect(excludesChange).to.equal(true);

diff --git a/src/expoDebuggers.ts b/src/expoDebuggers.ts
@@ -26,7 +26,10 @@ interface ExpoDebugConfig extends vscode.DebugConfiguration {
 }
 
 export class ExpoDebuggersProvider implements vscode.DebugConfigurationProvider {
-  constructor(extension: vscode.ExtensionContext, protected projects: ExpoProjectCache) {
+  constructor(
+    extension: vscode.ExtensionContext,
+    protected projects: ExpoProjectCache
+  ) {
     extension.subscriptions.push(
       vscode.debug.registerDebugConfigurationProvider(
         DEBUG_TYPE,

diff --git a/src/extension.ts b/src/extension.ts
@@ -29,9 +29,13 @@ export async function activate(context: vscode.ExtensionContext) {
 
     reporter?.sendTelemetryEvent(TelemetryEvent.ACTIVATED);
   } catch (error) {
-    reporter?.sendTelemetryException(error);
     vscode.window.showErrorMessage(
       `Oops, looks like we can't fully activate Expo Tools: ${error.message}`
     );
+
+    reporter?.sendTelemetryErrorEvent(TelemetryEvent.ACTIVATED, {
+      message: error.message,
+      stack: error.stack,
+    });
   }
 }
diff --git a/src/preview/CodeProvider.ts b/src/preview/CodeProvider.ts
@@ -37,7 +37,10 @@ export class CodeProvider implements vscode.TextDocumentContentProvider {
 
   readonly defaultLanguage: CodeProviderLanguage = 'json';
 
-  constructor(public _document: vscode.TextDocument, public options: CodeProviderOptions) {
+  constructor(
+    public _document: vscode.TextDocument,
+    public options: CodeProviderOptions
+  ) {
     this.scheme = `expo-config-${this.options.type}`;
     this.projectRoot = getProjectRoot(this._document.fileName) ?? this._document.fileName;
     if (this.projectRoot === this._document.fileName) {

diff --git a/src/utils/telemetry.ts b/src/utils/telemetry.ts
@@ -41,28 +41,11 @@ export function setupTelemetry(context: ExtensionContext) {
   return reporter;
 }
 
-/**
- * Wrap a block inside an error telemetry reporter.
- * This will re-throw the error after reporting it.
- */
-export async function withErrorTelemetry<T>(
-  action: () => T | Promise<T>,
-  properties?: TelemetryEventProperties,
-  measurements?: TelemetryEventMeasurements
-): Promise<T> {
-  try {
-    return await action();
-  } catch (error) {
-    reporter?.sendTelemetryException(error, properties, measurements);
-    throw error;
-  }
-}
-
 export function featureTelemetry(
   feature: 'command' | 'debugger',
   command: string,
   properties?: TelemetryEventProperties,
   measurements?: TelemetryEventMeasurements
 ) {
-  return reporter?.sendTelemetryEvent(`${feature}/${command}`, properties);
+  return reporter?.sendTelemetryEvent(`${feature}/${command}`, properties, measurements);
 }
diff --git a/tsconfig.json b/tsconfig.json
@@ -1,8 +1,7 @@
 {
 	"exclude": ["out", "node_modules", ".vscode-test", "test/fixture"],
-  "extends": "@tsconfig/node16/tsconfig.json",
+  "extends": "@tsconfig/node18",
   "compilerOptions": {
-    "moduleResolution": "node",
     "outDir": "out",
     "sourceMap": true,
     "rootDir": ".",