Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use mocha instead of jest to avoid hacks #208

Merged
merged 13 commits into from
Aug 31, 2023

Conversation

byCedric
Copy link
Member

Linked issue

This pulls Jest from the testing setup, and replaces it with Mocha. The reason for this are:

  • Impossible to upgrade Jest due to various system overwrites that aren't possible within Electron
  • Newer VS Code versions resulting in unexpected crashes due to Jest internals

@byCedric byCedric force-pushed the @bycedric/refactor/use-mocha-instead-of-jest branch 2 times, most recently from ef333c2 to 99d309c Compare August 30, 2023 15:43
@byCedric byCedric force-pushed the @bycedric/refactor/use-mocha-instead-of-jest branch from 99d309c to c1b2acb Compare August 30, 2023 15:44
@byCedric byCedric changed the title refactor: use mocha instead of jest to avoid needing hacks refactor: use mocha instead of jest to avoid hacks Aug 30, 2023
@byCedric byCedric force-pushed the @bycedric/refactor/use-mocha-instead-of-jest branch 2 times, most recently from 59805a0 to 3b4ab52 Compare August 30, 2023 16:46
@byCedric byCedric force-pushed the @bycedric/refactor/use-mocha-instead-of-jest branch from 3b4ab52 to 238b12b Compare August 30, 2023 16:53
@byCedric byCedric force-pushed the @bycedric/refactor/use-mocha-instead-of-jest branch from b8ef33d to f20b2fb Compare August 30, 2023 18:04
@byCedric byCedric merged commit 92352ac into main Aug 31, 2023
13 checks passed
@byCedric byCedric deleted the @bycedric/refactor/use-mocha-instead-of-jest branch August 31, 2023 08:27
expo-bot added a commit that referenced this pull request Sep 1, 2023
## [1.1.0](1.0.7...1.1.0) (2023-09-01)

### New features

* allow `expo.*` properties as root properties without `expo` definition ([#217](#217)) ([c71ccbc](c71ccbc))

### Bug fixes

* downgrade conventional commit preset for semantic release ([d392f89](d392f89))
* replace yarn with npm due to issues with `@isaacs/cliui` ([#209](#209)) ([f046f1d](f046f1d))

### Code changes

* bump minimum vscode version to `1.78.2` ([#211](#211)) ([602946c](602946c))
* consolidate the testing fixtures ([#218](#218)) ([fe00632](fe00632))
* use mocha instead of jest to avoid crashes and other issues ([#208](#208)) ([92352ac](92352ac))
* use proper `dependencies` instead of `devDependencies` only ([#214](#214)) ([d0f60eb](d0f60eb))

### Other chores

* add missing `permissions` to github workflow when dry-running release ([#205](#205)) ([7a78a92](7a78a92))
* allow dry-run to test push verification in release workflow ([a9b6c92](a9b6c92))
* clean up log-clutter in test output ([#215](#215)) ([9f03f24](9f03f24))
* clean up typo in `.gitignore` ([3bb248d](3bb248d))
* clean up yarn-specific workarounds ([36093a0](36093a0))
* upgrade tooling to latest versions ([#212](#212)) ([0324b10](0324b10))
expo-bot added a commit that referenced this pull request Sep 1, 2023
## [1.1.0](1.0.7...1.1.0) (2023-09-01)

### New features

* allow `expo.*` properties as root properties without `expo` definition ([#217](#217)) ([c71ccbc](c71ccbc))

### Bug fixes

* downgrade conventional commit preset for semantic release ([d392f89](d392f89))
* replace yarn with npm due to issues with `@isaacs/cliui` ([#209](#209)) ([f046f1d](f046f1d))

### Code changes

* bump minimum vscode version to `1.78.2` ([#211](#211)) ([602946c](602946c))
* consolidate the testing fixtures ([#218](#218)) ([fe00632](fe00632))
* use mocha instead of jest to avoid crashes and other issues ([#208](#208)) ([92352ac](92352ac))
* use proper `dependencies` instead of `devDependencies` only ([#214](#214)) ([d0f60eb](d0f60eb))

### Other chores

* add missing `permissions` to github workflow when dry-running release ([#205](#205)) ([7a78a92](7a78a92))
* add prerelease support in publish workflow ([6f8240e](6f8240e))
* allow dry-run to test push verification in release workflow ([a9b6c92](a9b6c92))
* clean up log-clutter in test output ([#215](#215)) ([9f03f24](9f03f24))
* clean up typo in `.gitignore` ([3bb248d](3bb248d))
* clean up yarn-specific workarounds ([36093a0](36093a0))
* emphasize the creation of a release instead of publish ([0eed055](0eed055))
* upgrade tooling to latest versions ([#212](#212)) ([0324b10](0324b10))
* use authenticated Expo bot user for schema updates ([c91af9c](c91af9c))
@expo-bot
Copy link
Contributor

expo-bot commented Sep 1, 2023

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@expo expo deleted a comment from expo-bot Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants