Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean up log-clutter in test output #215

Merged
merged 3 commits into from
Aug 31, 2023
Merged

chore: clean up log-clutter in test output #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66cad8c
chore: try adding `DISPLAY` env var to avoid log cluttering
byCedric Aug 31, 2023
716e4fb
chore: try another variable based on reported vscode-test issues
byCedric Aug 31, 2023
dd20a11
refactor: move xvfb to a separate action
byCedric Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/actions/test-vscode/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: Test VS Code
description: Run the integration tests within VS Code

inputs:
command:
description: The test command to execute with xvfb-run
required: true
type: string

runs:
using: composite
steps:
- name: 🧪 Test on Linux
if: ${{ runner.os == 'Linux' }}
run: xvfb-run -a ${{ inputs.command }}
shell: bash
env:
# Unset wrong Electron setting,
# see: https://github.com/microsoft/vscode-test/issues/127
DBUS_SESSION_BUS_ADDRESS: null

- name: 🧪 Test on MacOS/Windows
if: ${{ runner.os != 'Linux' }}
run: ${{ inputs.command }}
shell: bash
17 changes: 8 additions & 9 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- name: 🏗 Setup project
uses: ./.github/actions/setup-project

- name: ✅ Test scripts
- name: 🧪 Test scripts
run: npm run test:scripts

bundled:
Expand Down Expand Up @@ -64,7 +64,9 @@ jobs:
npm install --no-package-lock --ignore-scripts

- name: 🧪 Test project
run: xvfb-run -a npm run test:vscode
uses: ./.github/actions/test-vscode
with:
command: npm run test:vscode
env:
VSCODE_VERSION: stable

Expand Down Expand Up @@ -99,10 +101,7 @@ jobs:
: vscode
core.exportVariable('VSCODE_VERSION', target)

- name: 🧪 Test project (Linux)
if: ${{ runner.os == 'Linux' }}
run: xvfb-run -a npm run test:vscode

- name: 🧪 Test project (MacOS/Windows)
if: ${{ runner.os != 'Linux' }}
run: npm run test:vscode
- name: 🧪 Test project
uses: ./.github/actions/test-vscode
with:
command: npm run test:vscode