Fix exponent parse error

expr-lang · Mar 2, 2020 · 9217dda · 9217dda
1 parent 2482543
commit 9217dda
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/parser/parser.go b/parser/parser.go
@@ -282,7 +282,7 @@ func (p *parser) parsePrimaryExpression() Node {
 	case Number:
 		p.next()
 		value := strings.Replace(token.Value, "_", "", -1)
-		if strings.Contains(value, ".") {
+		if strings.ContainsAny(value, ".eE") {
 			number, err := strconv.ParseFloat(value, 64)
 			if err != nil {
 				p.error("invalid float literal: %v", err)

diff --git a/parser/parser_test.go b/parser/parser_test.go
@@ -39,6 +39,10 @@ func TestParse(t *testing.T) {
 			"2.5",
 			&ast.FloatNode{Value: 2.5},
 		},
+		{
+			"1e9",
+			&ast.FloatNode{Value: 1e9},
+		},
 		{
 			"true",
 			&ast.BoolNode{Value: true},
-Original file line number
+Diff line change
@@ Expand Up / @@ -39,6 +39,10 @@ func TestParse(t *testing.T) { @@
     			"2.5",
     			&ast.FloatNode{Value: 2.5},
     		},
+    		{
+    			"1e9",
+    			&ast.FloatNode{Value: 1e9},
+    		},
     		{
     			"true",
     			&ast.BoolNode{Value: true},
@@ Expand Down @@