feat: codegen to fetch from env without reflect #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi 👋 |
|
Added! |
|
Thanks. |
antonmedv
reviewed
Dec 3, 2021
| echo(`--imports`) | ||
| echo(``) | ||
|
|
||
| echoRaw(`func toInt(a interface{}) int { |
There was a problem hiding this comment.
What about exporting it from vm.ToInt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch methods generates for all struct/map/array/string named types (exception is map types with unnamed not basic key type like
map[struct{...}]int)To generate just call exprgen with pkg paths as arguments:
exprgen pkg1 pkg2...After call, file
*pkg_name*_exprgen.gowill be createdWhat do you think about it?