Skip to content

Commit

Permalink
npm: exclude website and docs from publish
Browse files Browse the repository at this point in the history
  • Loading branch information
@fedeci
fedeci committed Sep 28, 2021
1 parent 94d5426 commit bc2c237
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,14 @@
"main": "./src/index.js",
"types": "./src/index.d.ts",
"files": [
"docs",
"src",
"check",
"filter",
"!**/*.spec.ts",
"!**/*.ts",
"**/*.d.ts"
"**/*.d.ts",
"!website",
"!docs"
],
"scripts": {
"build": "tsc",
Expand Down

6 comments on commit bc2c237

@gustavohenke
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it slightly useful to bundle docs when they are in markdown format 🤔
But the website dir is definitely not needed

@fedeci
Copy link
Member Author

@fedeci fedeci commented on bc2c237 Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs are the same of the website, I am not sure how much they get used there

@gustavohenke
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although...

gustavohenke ~/Projects/express-validator (master) $ npm pack
npm notice
npm notice 📦  express-validator@6.12.1
npm notice === Tarball Contents ===
npm notice 1.1kB  LICENSE
npm notice 1.2kB  README.md
npm notice 345B   check/index.d.ts
npm notice 1.6kB  check/index.js
npm notice 7.2kB  declarations/validator.d.ts
npm notice 4.6kB  docs/api-check.md
npm notice 2.5kB  docs/api-filter.md
npm notice 2.8kB  docs/api-matched-data.md
npm notice 4.4kB  docs/api-sanitization-chain.md
npm notice 9.9kB  docs/api-validation-chain.md
npm notice 4.6kB  docs/api-validation-result.md
npm notice 1.8kB  docs/faq.md
npm notice 3.3kB  docs/feature-custom-validators-sanitizers.md
npm notice 4.3kB  docs/feature-error-messages.md
npm notice 3.7kB  docs/feature-running-imperatively.md
npm notice 1.3kB  docs/feature-sanitization.md
npm notice 2.1kB  docs/feature-schema-validation.md
npm notice 843B   docs/feature-whole-body-validation.md
npm notice 1.1kB  docs/feature-wildcards.md
npm notice 3.7kB  docs/index.md
npm notice 4.0kB  docs/migration-v5-to-v6.md
npm notice 204B   filter/index.d.ts
npm notice 1.2kB  filter/index.js
npm notice 2.0kB  package.json
npm notice 1.5kB  src/base.d.ts
npm notice 300B   src/base.js
npm notice 567B   src/chain/context-handler-impl.d.ts
npm notice 1.3kB  src/chain/context-handler-impl.js
npm notice 316B   src/chain/context-handler.d.ts
npm notice 77B    src/chain/context-handler.js
npm notice 757B   src/chain/context-runner-impl.d.ts
npm notice 3.0kB  src/chain/context-runner-impl.js
npm notice 292B   src/chain/context-runner.d.ts
npm notice 77B    src/chain/context-runner.js
npm notice 352B   src/chain/index.d.ts
npm notice 1.1kB  src/chain/index.js
npm notice 368B   src/chain/sanitization-chain.d.ts
npm notice 77B    src/chain/sanitization-chain.js
npm notice 1.1kB  src/chain/sanitizers-impl.d.ts
npm notice 2.8kB  src/chain/sanitizers-impl.js
npm notice 822B   src/chain/sanitizers.d.ts
npm notice 77B    src/chain/sanitizers.js
npm notice 520B   src/chain/validation-chain.d.ts
npm notice 77B    src/chain/validation-chain.js
npm notice 4.2kB  src/chain/validators-impl.d.ts
npm notice 10.3kB src/chain/validators-impl.js
npm notice 4.0kB  src/chain/validators.d.ts
npm notice 77B    src/chain/validators.js
npm notice 513B   src/context-builder.d.ts
npm notice 913B   src/context-builder.js
npm notice 179B   src/context-items/bail.d.ts
npm notice 328B   src/context-items/bail.js
npm notice 360B   src/context-items/chain-condition.d.ts
npm notice 479B   src/context-items/chain-condition.js
npm notice 169B   src/context-items/context-item.d.ts
npm notice 77B    src/context-items/context-item.js
npm notice 341B   src/context-items/custom-condition.d.ts
npm notice 798B   src/context-items/custom-condition.js
npm notice 407B   src/context-items/custom-validation.d.ts
npm notice 1.1kB  src/context-items/custom-validation.js
npm notice 179B   src/context-items/index.d.ts
npm notice 835B   src/context-items/index.js
npm notice 469B   src/context-items/sanitization.d.ts
npm notice 822B   src/context-items/sanitization.js
npm notice 460B   src/context-items/standard-validation.d.ts
npm notice 626B   src/context-items/standard-validation.js
npm notice 1.1kB  src/context.d.ts
npm notice 3.1kB  src/context.js
npm notice 530B   src/index.d.ts
npm notice 1.0kB  src/index.js
npm notice 287B   src/matched-data.d.ts
npm notice 1.6kB  src/matched-data.js
npm notice 195B   src/middlewares/check.d.ts
npm notice 1.0kB  src/middlewares/check.js
npm notice 563B   src/middlewares/one-of.d.ts
npm notice 2.4kB  src/middlewares/one-of.js
npm notice 737B   src/middlewares/sanitization-chain-builders.d.ts
npm notice 754B   src/middlewares/sanitization-chain-builders.js
npm notice 187B   src/middlewares/sanitize.d.ts
npm notice 1.2kB  src/middlewares/sanitize.js
npm notice 1.9kB  src/middlewares/schema.d.ts
npm notice 2.5kB  src/middlewares/schema.js
npm notice 895B   src/middlewares/validation-chain-builders.d.ts
npm notice 741B   src/middlewares/validation-chain-builders.js
npm notice 9.9kB  src/options.d.ts
npm notice 77B    src/options.js
npm notice 219B   src/select-fields.d.ts
npm notice 2.7kB  src/select-fields.js
npm notice 145B   src/utils.d.ts
npm notice 1.1kB  src/utils.js
npm notice 901B   src/validation-result.d.ts
npm notice 1.6kB  src/validation-result.js

Maybe including website was not needed?

@fedeci
Copy link
Member Author

@fedeci fedeci commented on bc2c237 Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you on npm@7?

@gustavohenke
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, v7.20.3

@fedeci
Copy link
Member Author

@fedeci fedeci commented on bc2c237 Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably that's the cause, I'm still in the deprecated zone😃

Please sign in to comment.