Also use the qs module for the simple parser #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougwilson
force-pushed
the
master
branch
3 times, most recently
from
0ad1d88
to
2a2f471
Compare
46 tasks
|
We are preparing to release 2.0, and to reduce churn and help us I retargeted this to that branch. Would you be able to rebase this so I can merge it there? |
papandreou
force-pushed
the
feature/qsAlways
branch
from
86c7614
to
cd81d5d
Compare
papandreou
force-pushed
the
feature/qsAlways
branch
from
cd81d5d
to
9b83d81
Compare
|
@wesleytodd, absolutely! Done. |
|
Before I merge this, @ljharb mind taking a quick look to make sure this is good to land for v5? It appears your last comment was in 2020 just mentioning to update, which we will for sure ensure we are before publishing. |
|
still LGTM! |
papandreou
added a commit
to papandreou/body-parser
that referenced
this pull request
Jul 27, 2024
* 2.x: (98 commits) fix(deps): raw-body@^3.0.0 (expressjs#529) Also use the qs module for the simple parser (expressjs#387) feat!: remove node less than 18 from ci 2.0.0-beta.2 docs: add missing history entry tests: enable strict mode Remove deprecated bodyParser() combination middleware build: remove conditional code coverage deps: debug@3.1.0 deps: iconv-lite@0.5.2 deps: raw-body@3.0.0-beta.1 1.20.2 Fix strict json error message on Node.js 19+ deps: raw-body@2.5.2 build: eslint@8.34.0 build: Node.js@18.14 build: Node.js@14.21 deps: content-type@~1.0.5 build: eslint-plugin-promise@6.1.1 build: supertest@6.3.3 ...
papandreou
added a commit
to papandreou/body-parser
that referenced
this pull request
Jul 27, 2024
* 2.x: (98 commits) fix(deps): raw-body@^3.0.0 (expressjs#529) Also use the qs module for the simple parser (expressjs#387) feat!: remove node less than 18 from ci 2.0.0-beta.2 docs: add missing history entry tests: enable strict mode Remove deprecated bodyParser() combination middleware build: remove conditional code coverage deps: debug@3.1.0 deps: iconv-lite@0.5.2 deps: raw-body@3.0.0-beta.1 1.20.2 Fix strict json error message on Node.js 19+ deps: raw-body@2.5.2 build: eslint@8.34.0 build: Node.js@18.14 build: Node.js@14.21 deps: content-type@~1.0.5 build: eslint-plugin-promise@6.1.1 build: supertest@6.3.3 ...
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up from #326