Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose arrayLimit #58

Closed
wants to merge 3 commits into from
Closed

Expose arrayLimit #58

wants to merge 3 commits into from

Conversation

mike-zorn
Copy link

I've run into the same issue as #46, so I've extended the api to allow that to be set, but in a way which doesn't make the dependency on qs so obvious.

@dougwilson
Copy link
Contributor

Hi! Please read the discussion over at #55 (comment) while I look at your PR. The gist is unless the option will change the behavior of extended: false in some way, it won't be added.

@mike-zorn
Copy link
Author

Ah, OK. Sounds like this one isn't welcome then. 😛

@mike-zorn mike-zorn closed this Oct 8, 2014
@dougwilson
Copy link
Contributor

Well, it's not that it's not welcome, per. se., but just starts to tightly bind our interface to the qs interface instead of a general urlencoded interface. I do want people to, in the end, choose these options, though. In fact, in the next major, arrayLimit for the standard extended: true will just be 0, as it's the most sane option, i.m.o :)

@mike-zorn
Copy link
Author

If anyone is looking for this before v2 comes out, I made a module which is the workaround suggested in #55.

@jcready
Copy link

jcready commented Oct 8, 2014

👍

dougwilson added a commit that referenced this pull request Oct 30, 2014
closes #42
closes #43
closes #46
closes #58
closes #60
closes #61
closes #65
dougwilson added a commit that referenced this pull request Nov 22, 2014
closes #42
closes #43
closes #46
closes #58
closes #60
closes #61
closes #65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants