-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: Let's talk about HISTORY.md #293
Comments
I definitely think it makes sense to automate it, if it can be done nicely. I use |
This should be automated to avoid opening unnecessary PRs for updating the history or delaying the same PRs for something that can be automated. I believe the popular way to do this is by using changesets |
I'm in favor of using both the A By maintaining both GitHub Releases and a |
This issue also opens up a discussion about adopting Conventional Commits. By using the Conventional Commits specification, we can clearly identify the nature of each change—whether it’s a new feature, a bug fix, a chore, or something else. This practice can improve clarity in the project’s commit history, making it easier for contributors and maintainers to understand the intent behind each commit at a glance. Using Conventional Commits could align well with maintaining both |
The problem with GitHub Releases is that once you have more than zero of them, tags that lack a release are almost impossible to find. So, it’s either “do a release for every tag, since forever for forever” or “never do a release”. The problem with conventional commits is that it’s not sufficiently configurable. |
Updating the history also causes conflicts with other PRs that are also updating their history for their PR, which blocks the PR until the author fixes it, or if they allow us, we can fix the conflict. If you want to try automating this, compression could be a good candidate. |
That shouldn’t be much of a problem, and virtually nobody unchecks the “allow edits” checkbox, so a maintainer can always just go update the PR. |
We for sure need to automate it, and I agree we should move to |
So far, it seems like many packages are using
HISTORY.md
. I have some questions:HISTORY.md
), as we currently do in Express?Regardless, if we decide to keep
HISTORY.md
, we need to define what should be included there, as there’s currently no clear documentation on it, and it’s a manual step prone to errors. For instance, I merged some PRs that didn’t include updates to the file, so I needed to amend them later in the branches, etc.We stated a discussion last week in the TC meeting and @blakeembrey had a very clear ideas for the future of
HISTORY,md
.What do you think?
The text was updated successfully, but these errors were encountered: