Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General changelog #1656

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Conversation

bjohansebas
Copy link
Member

The changelog is generalized so that it is not only for version 4

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 523dc0f
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/6728cf93a777d10008bc4a32
😎 Deploy Preview https://deploy-preview-1656--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bjohansebas
Copy link
Member Author

@UlisesGascon @wesleytodd, what is the possibility of managing two histories in the Express repository, meaning:

  • HISTORY.md: As it has been functioning
  • HISTORY-REMOTE.md: The changelog adapted for the website

This would help keep the page updated with the latest changes in the library; we would just need to create the script to fetch HISTORY-REMOTE.md, now that external documentation can be automated.

@bjohansebas bjohansebas marked this pull request as ready for review October 26, 2024 00:49
@bjohansebas bjohansebas requested a review from a team October 26, 2024 00:49
@UlisesGascon
Copy link
Member

@bjohansebas this might we relevant: expressjs/discussions#293

@bjohansebas
Copy link
Member Author

@UlisesGascon While the future of history.md is being decided, we could release this to keep the page updated

@bjohansebas bjohansebas merged commit d557cca into expressjs:gh-pages Nov 4, 2024
5 of 6 checks passed
@bjohansebas bjohansebas deleted the general-changelog branch November 4, 2024 13:45
chrisdel101 pushed a commit to chrisdel101/expressjs.com that referenced this pull request Nov 11, 2024
* general changelog

* add version 5 releases
@wesleytodd
Copy link
Member

I have not been able to keep up with all this work, but I am not sure if I agree this should have landed. It is in the 4.x directory, and I think the idea from the past was that we would create a new one in the 5.x directory for the new major. I dont think we should back this out, but I do think we should consider if this was their right direction to take and revisit it after we do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants