-
-
Notifications
You must be signed in to change notification settings - Fork 16.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves compileQueryParser to separate module #3259
base: 5.0
Are you sure you want to change the base?
Conversation
Probably should hard-pin the |
ca849e1
to
e8e2c4c
Compare
I updated that in the module, and assuming it will move into the express family somewhere I used the tilde in here. |
Anything blocking us from moving forward? Do we need to move the repo or can it live where it is? |
This change is neither breaking nor required to ship v5. This was done so that it could be used individually in another project I was working on at the time, but is otherwise not necessary. I am going to remove the v5 label and we can decide if it is worth doing later as a minor. |
Moved this functionality to a separate module so I could use it in my other package. It appears no tests were originally written, so I added some in the module. If you would like we can move this repo under pillar, or here, just let me know.
https://github.com/wesleytodd/compile-query-parser