Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query: deprecate extended query parser #4208

Closed
wants to merge 8 commits into from
Closed

query: deprecate extended query parser #4208

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
13f780b
query: deprecate extended query parser
gireeshpunathil Mar 6, 2020
84dd1aa
fixup: address review comments:
gireeshpunathil Mar 9, 2020
a6242cf
fixup: throw deprecation warning only in the absence of user over-ride
gireeshpunathil Mar 9, 2020
77ec8a1
fixup: change const in favor of var
gireeshpunathil Mar 11, 2020
151e71a
fixup: address subapp scenario
gireeshpunathil Mar 13, 2020
abf0df0
fixup: confine deprecation per app
gireeshpunathil Mar 20, 2020
ad8981c
fixup: privatise deprecation trackere variable
gireeshpunathil Mar 25, 2020
b311f27
lint: standardjs
dougwilson Mar 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,12 @@ app.defaultConfiguration = function defaultConfiguration() {
var env = process.env.NODE_ENV || 'development';

// default settings
this._defaultExtendedQueryParser = true
this.enable('x-powered-by');
this.set('etag', 'weak');
this.set('env', env);
this.set('query parser', 'extended');
this._defaultExtendedQueryParser = true
this.set('subdomain offset', 2);
this.set('trust proxy', false);

Expand Down Expand Up @@ -141,6 +143,10 @@ app.lazyrouter = function lazyrouter() {
strict: this.enabled('strict routing')
});

if (this._defaultExtendedQueryParser) {
deprecate('default extended query parser deprecated, set explicitly to override')
}

this._router.use(query(this.get('query parser fn')));
this._router.use(middleware.init(this));
}
Expand Down Expand Up @@ -367,6 +373,7 @@ app.set = function set(setting, val) {
break;
case 'query parser':
this.set('query parser fn', compileQueryParser(val));
this._defaultExtendedQueryParser = false
break;
case 'trust proxy':
this.set('trust proxy fn', compileTrust(val));
Expand Down