Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add license readme badge #5409

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

lukeed
Copy link

@lukeed lukeed commented Jan 25, 2024

This service recursively checks/lists all licenses within a package's dependency graph.

In this case, express has 61 total licenses within its graph. Because there are 3 different license types (MIT, ISC, BSD3) – and they're all "green" licenses — the total number of licenses is shown.

This service recursively checks/lists all licenses within a package's dependency graph. 

In this case, express has 61 total licenses within its graph. Because there are 3 different license types (MIT, ISC, BSD3) – and they're all "green" licenses — the total number of licenses is shown
@dougwilson
Copy link
Contributor

Thank you. I'm not 100% this needs to be a badge, but at the very least needs to be one fr badgen.net

@lukeed
Copy link
Author

lukeed commented Jan 25, 2024

It’s just here as an option in case you’d like it :)

the difference from badgen is that they only display express’ license directly (MIT) but they don’t analyze the whole graph. Given that Express is the foundation to so many projects, this is a lot more helpful to legal teams in know that “everything here is in the clear” vs “just this single package has an acceptable license”

@dougwilson
Copy link
Contributor

Oh, sorry, I don't mean it has to use some existing source badgen.net already has, only that our policy is only badgen.net badges in the readme. You can have badgen.net add this site as a source.

I took a look at the badge and it currently says "licenses 62" -- i mistakenly assumed based on your description it would list the three types.

@lukeed
Copy link
Author

lukeed commented Jan 25, 2024

Ah gotcha. The site lists the total license count and green/red status. So it also doubles as a total dependency count. Eventually it’ll have the ability to export all (62, in this case) licenses to a ZIP/txt file for distribution compliance (since so many bundled projects omit/ignore licenses outright)

@bjohansebas
Copy link
Member

I don't think we need this, but if the others are okay with it, I can create a new PR since I see that this one has conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants