Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSSF Scorecard badge #5436

Merged
merged 3 commits into from
Jul 28, 2024

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Feb 2, 2024

Main Changes

I am not sure what are our current policies regarding adding badges to the readme file, but I will love to suggest to include the OSSF Scorecard scoring as we are doing an active effort to improve it (see: expressjs/security-wg#2)

Changelog

@UlisesGascon UlisesGascon marked this pull request as ready for review February 2, 2024 16:44
Copy link
Member

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@renatocfrancisco renatocfrancisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 yee

@UlisesGascon UlisesGascon added the semver-ignore This change does not have any impact in semver (docs, tooling, etc..) label Apr 17, 2024
@UlisesGascon UlisesGascon requested a review from a team April 29, 2024 08:09
@UlisesGascon
Copy link
Member Author

The GitHub UI failed while resolving the merge conflicts, so I will handle it manually.

Readme.md Outdated Show resolved Hide resolved
Copy link
Member

@jonchurch jonchurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder to remove the conflict markers

Copy link
Member

@sheplu sheplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UlisesGascon UlisesGascon merged commit 2177f67 into expressjs:master Jul 28, 2024
2 checks passed
@UlisesGascon UlisesGascon deleted the docs/add-scorecard-badge branch July 28, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-ignore This change does not have any impact in semver (docs, tooling, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants