Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dev dependencies #5500

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sheplu
Copy link
Member

@sheplu sheplu commented Feb 24, 2024

Update dev dependencies only to use up to date packages

edit:

  • run 1: failing before 14 because of JavaScript

@sheplu sheplu force-pushed the update-devdeps branch 8 times, most recently from c796950 to 11a67ea Compare February 24, 2024 13:55

- name: Node.js 5.x
node-version: "5.12"
npm-i: mocha@5.2.0 nyc@11.9.0 supertest@3.4.2
npm-i: mocha@5.2.0 nyc@11.9.0 supertest@3.4.2 marked@0.7.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this one is not a mistake, can we add a comment about why it is different than the rest?

@@ -36,63 +36,63 @@ jobs:
include:
- name: Node.js 0.10
node-version: "0.10"
npm-i: mocha@3.5.3 nyc@10.3.2 supertest@2.0.0
npm-i: mocha@3.5.3 nyc@10.3.2 supertest@2.0.0 marked@0.7.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I guess this one as well

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants