Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Appveyor windows testing with GHA #5599
Replace Appveyor windows testing with GHA #5599
Changes from 49 commits
42d1509
ccb9c89
4d7a238
2bd8990
48c1124
6751ab3
fdb5e6f
763e9ec
c0abdab
44fbd93
8f6c183
4fd8df3
dd1651d
c5464b6
fa68657
f53fc7b
752dfcc
a2f368a
67c8a54
e10aa7c
67fb980
6ebb774
b7034f6
57f16eb
1dc71e6
75c9a3b
449c62f
70a0192
fbc8e46
af7559b
8cb2adf
b4e8cb5
ab17be3
a9555f9
7d9ab0a
508d5ac
3dad18a
15f2860
5eede5f
c8a9ffd
a9b0967
c49ea96
7f92a11
c394f73
c5b333f
f4a0909
c36797b
814b26c
611556b
0c536b2
e34a3e6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the comments in the matrix include section to understand why I added a step to install npm for a few versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dropped configuring npm to ignore package-lock and shrinkwrap
We have .npmrc set to package-lock: false, and this same PR updates gitignore to ignore shrinkwrap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason not to also move this config into the
.npmrc
if this is what we need? I do wonder what the reason was to configure this at all in the past, do you know that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that Im adding shrinkwrap to gitignore, we don't generate it, but we did go out of our way in the CI before to configure node to ignore it
Comfortable removing that config part, and just making sure we never commit it