Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add table of contents, tc/triager lists to readme #5619

Merged
merged 36 commits into from
May 8, 2024
Merged

doc: add table of contents, tc/triager lists to readme #5619

merged 36 commits into from
May 8, 2024

Conversation

mertcanaltin
Copy link
Member

@mertcanaltin mertcanaltin commented Apr 23, 2024 •
edited
Loading

I have created a table and I think this place can provide convenience
In addition, I created areas introducing cooperation, technical committee, triagers.

added space for Code of Conduct

(unfortunately, some e-mails are missing, I couldn't find them :(
I could not add some people, I can add the missing participants 🙏)

@UlisesGascon @wesleytodd @CBID2

@mertcanaltin mertcanaltin mentioned this pull request Apr 23, 2024
Open
krzysdz
krzysdz reviewed Apr 23, 2024
View reviewed changes
Readme.md Outdated Show resolved Hide resolved
@mertcanaltin @krzysdz
Update Readme.md
d3ff5b0 
Co-authored-by: krzysdz <krzysdz@users.noreply.github.com>
krzysdz
krzysdz reviewed Apr 23, 2024
View reviewed changes
Readme.md Outdated Show resolved Hide resolved
UlisesGascon
UlisesGascon reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will suggest to add all the members from the teams before we merge the PR, so we avoid more PRs in the following days for additions/updates if possible.

Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
@UlisesGascon UlisesGascon added docs semver-ignore This change does not have any impact in semver (docs, tooling, etc..) labels Apr 23, 2024
mertcanaltin and others added 2 commits April 23, 2024 13:16
@mertcanaltin @UlisesGascon
Update Readme.md
07b36aa 
Co-authored-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@mertcanaltin @UlisesGascon
Update Readme.md
b50fbe9 
Co-authored-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
CBID2
CBID2 suggested changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @mertcanaltin. There's still some parts that need improvement so I gave some suggestions to help you

Readme.md Outdated Show resolved Hide resolved
Readme.md Show resolved Hide resolved
@mertcanaltin @CBID2
Update Readme.md
6b1461b 
Co-authored-by: Christine Belzie <105683440+CBID2@users.noreply.github.com>
wesleytodd
wesleytodd requested changes Apr 23, 2024
View reviewed changes
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
@UlisesGascon UlisesGascon mentioned this pull request Apr 24, 2024
Closed
wesleytodd
wesleytodd approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but I think I have a very minor nit pick. I think this is better if each person is a single line. It makes it easier to follow changes imo. Not necessary to change, but imo would be better.

aravindvnair99
aravindvnair99 suggested changes Apr 24, 2024
View reviewed changes
Copy link
Member

@aravindvnair99 aravindvnair99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have more triagers who are missing from the list including myself.

@mertcanaltin
Copy link
Member Author

I added the missing triagers
based on this list: https://github.com/orgs/expressjs/teams/triagers

jonchurch
jonchurch reviewed Apr 28, 2024
View reviewed changes
Readme.md Outdated Show resolved Hide resolved
jonchurch
jonchurch reviewed Apr 28, 2024
View reviewed changes
Readme.md Outdated Show resolved Hide resolved
jonchurch
jonchurch reviewed Apr 28, 2024
View reviewed changes
Readme.md Outdated Show resolved Hide resolved
This was referenced Sep 12, 2024
Open
Closed
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Closed
Open
@louiechristie louiechristie mentioned this pull request Sep 17, 2024
Merged
@MilkaChucky MilkaChucky mentioned this pull request Sep 17, 2024
Merged
@andrejkurusiov andrejkurusiov mentioned this pull request Sep 17, 2024
Merged
@jjj333-p jjj333-p mentioned this pull request Sep 17, 2024
Merged
This was referenced Sep 17, 2024
Merged
Merged
This was referenced Sep 18, 2024
Merged
Merged
This was referenced Sep 19, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzysdz krzysdz krzysdz left review comments

@aravindvnair99 aravindvnair99 aravindvnair99 requested changes

@CBID2 CBID2 CBID2 requested changes

@wesleytodd wesleytodd wesleytodd approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@jonchurch jonchurch jonchurch approved these changes

Assignees
No one assigned
Labels
docs semver-ignore This change does not have any impact in semver (docs, tooling, etc..)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mertcanaltin @jonchurch @wesleytodd @UlisesGascon @krzysdz @aravindvnair99 @CBID2