Refactor variable name from lazyrouter to lazyRouter for camel case consistency #5755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want to get permission to proceed. Therefore, overall changes have not been made. What do you think about this? |
|
This is an undocumented and intended to be private method but changing it would be a breaking change which cannot land in v4. IMO we should not make changes to it until we remove it completely in a future major. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The camel case convention seems to be the standard naming convention used in this project, and "lazyrouter" does not conform to this standard. I believe it would be better to change it to "lazyRouter". What do you think? Additionally, are there any other areas that might need revision?