-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.x: Upgrading merge-descriptors
with allowing minors
#5782
5.x: Upgrading merge-descriptors
with allowing minors
#5782
Conversation
Hi @RobinTail 👋 I hope you are doing fine. I am requesting you to move it v2. The idea is to upgrade all the dependencies first and then make node 18 as the minimum supported for express 5. |
done, @IamLizu && @wesleytodd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
A minor thing, could you please add this in the unreleased section in History file?
Edit: just letting you know that deps should be in alphabetical order.
done, @IamLizu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Similar to #5781 but for v5, with allowing minors according to the following request:
#5781 (comment)